feat: add std::string_view overload for Symbol::For#1722
Open
umuoy1 wants to merge 2 commits intonodejs:mainfrom
Open
feat: add std::string_view overload for Symbol::For#1722umuoy1 wants to merge 2 commits intonodejs:mainfrom
umuoy1 wants to merge 2 commits intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
+ Coverage 63.61% 63.65% +0.03%
==========================================
Files 3 3
Lines 2056 2058 +2
Branches 729 729
==========================================
+ Hits 1308 1310 +2
Misses 162 162
Partials 586 586 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@legendecas could you take a look at this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol::Forhad overloads for const std::string&, const char*, String, and napi_value, but was missing a std::string_view overload. This made it inconsistent with other APIs like String::New which already accept std::string_view, and forced users to convert std::string_view to std::string or const char* before calling Symbol::For.Adding the std::string_view overload provides a more consistent API surface and avoids unnecessary string copies.